conservatory
/
picrin
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[xhash] use strdup if possible

This commit is contained in:
Yuichi Nishiwaki 2013-11-26 08:23:45 -08:00
parent 673b66a723
commit bfa8b84b0e
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
extlib/xhash/xhash.h
View File

@ -62,8 +62,7 @@ xh_get(struct xhash *x, const char *key)
static inline struct xh_entry * static inline struct xh_entry *
xh_put(struct xhash *x, const char *key, int val) xh_put(struct xhash *x, const char *key, int val)
{ {
int idx, len; int idx;
char *new_key;
struct xh_entry *e; struct xh_entry *e;
if ((e = xh_get(x, key))) { if ((e = xh_get(x, key))) {
@ -71,14 +70,10 @@ xh_put(struct xhash *x, const char *key, int val)
return e; return e;
} }
len = strlen(key);
new_key = (char *)malloc(len+1);
strcpy(new_key, key);
idx = xh_hash(key) % x->size; idx = xh_hash(key) % x->size;
e = (struct xh_entry *)malloc(sizeof(struct xh_entry)); e = (struct xh_entry *)malloc(sizeof(struct xh_entry));
e->next = x->buckets[idx]; e->next = x->buckets[idx];
e->key = new_key; e->key = strdup(key);
e->val = val; e->val = val;
return x->buckets[idx] = e; return x->buckets[idx] = e;