conservatory
/
picrin
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Restrict char in the range of ASCII. 

picrin accepts the code `(char->integer (integer->char 128))` but the
result is machine-dependent, since the C `char` type can be either
signed or unsigned as permitted by the spec. Unfortunately, the result
of signed one is incompatible with Unicode-aware implementations. For
interoperability, we should deny the range beyond ASCII for now.

Ref: #211

Signed-off-by: Masanori Ogino <masanori.ogino@gmail.com>
This commit is contained in:
Masanori Ogino 2016-03-28 17:03:58 +09:00
parent 917704e9a4
commit 993d1813a1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
extlib/benz/char.c
View File

@ -22,6 +22,7 @@ pic_char_char_to_integer(pic_state *pic)
char c;
pic_get_args(pic, "c", &c);
assert((c & 0x80) == 0);
return pic_int_value(pic, c);
}
@ -33,7 +34,7 @@ pic_char_integer_to_char(pic_state *pic)
pic_get_args(pic, "i", &i);
if (i < 0 || i > 255) {
if (i < 0 || i > 127) {
pic_error(pic, "integer->char: integer out of char range", 1, pic_int_value(pic, i));
}